Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make http, grpc and elastic search request timeout configurable #60

Merged
merged 5 commits into from
Oct 6, 2023
Merged

chore: make http, grpc and elastic search request timeout configurable #60

merged 5 commits into from
Oct 6, 2023

Conversation

anjali9791
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Pull Request Test Coverage Report for Build 6405422624

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 87.242%
Totals Coverage Status
Change from base Build 5923054551: 0.002%
Covered Lines: 6202
Relevant Lines: 7109
💛 - Coveralls

haveiss
haveiss reviewed Oct 5, 2023
View reviewed changes
internal/server/server.go Outdated Show resolved Hide resolved
@anjali9791 anjali9791 force-pushed the update_timeouts branch 3 times, most recently from cd5f6fa to 49f42b9 Compare October 5, 2023 14:10
bsushmith
bsushmith reviewed Oct 5, 2023
View reviewed changes
internal/server/server.go Outdated Show resolved Hide resolved
bsushmith
bsushmith reviewed Oct 5, 2023
View reviewed changes
internal/server/server.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/es.go Outdated Show resolved Hide resolved
cli/server.go Outdated Show resolved Hide resolved
bsushmith
bsushmith reviewed Oct 5, 2023
View reviewed changes
internal/server/server.go Outdated Show resolved Hide resolved
bsushmith
bsushmith reviewed Oct 5, 2023
View reviewed changes
internal/server/server.go Outdated Show resolved Hide resolved
@anjali9791
Copy link
Author

@bsushmith @haveiss : Review comments have been incorporated.

@anjali9791 anjali9791 force-pushed the update_timeouts branch 2 times, most recently from 8790f7e to 641d422 Compare October 6, 2023 06:54
haveiss
haveiss requested changes Oct 6, 2023
View reviewed changes
compass.yaml.example Outdated Show resolved Hide resolved
compass.yaml.example Outdated Show resolved Hide resolved
compass.yaml.example Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_search_repository_test.go Outdated Show resolved Hide resolved
internal/store/elasticsearch/discovery_repository_test.go Outdated Show resolved Hide resolved
haveiss
haveiss approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@haveiss haveiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to update the title accordingly before merging

@anjali9791 anjali9791 changed the title chore: update grpc, http and elastic search request timeouts to 30 seconds chore: umake http, grpc and elastic search request timeout configurable Oct 6, 2023
@anjali9791 anjali9791 changed the title chore: umake http, grpc and elastic search request timeout configurable chore: make http, grpc and elastic search request timeout configurable Oct 6, 2023
@anjali9791 anjali9791 merged commit 868accc into main Oct 6, 2023
3 checks passed
@anjali9791 anjali9791 deleted the update_timeouts branch October 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsushmith bsushmith bsushmith left review comments

@haveiss haveiss haveiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anjali9791 @haveiss @bsushmith @anjaliagg9791